Skip to content

Optimise mesh grid for VSI#342

Merged
snk4tr merged 1 commit intomasterfrom
fix/optimise_meshgrid
Mar 30, 2023
Merged

Optimise mesh grid for VSI#342
snk4tr merged 1 commit intomasterfrom
fix/optimise_meshgrid

Conversation

@denproc
Copy link
Collaborator

@denproc denproc commented Feb 11, 2023

Closes #335

Proposed Changes

  • cache mesh grid to be used for Gabor filter generation and generation of coordinates

@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@codecov
Copy link

codecov bot commented Feb 11, 2023

Codecov Report

Merging #342 (894701a) into master (91a348e) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #342   +/-   ##
=======================================
  Coverage   92.01%   92.01%           
=======================================
  Files          34       34           
  Lines        2491     2491           
=======================================
  Hits         2292     2292           
  Misses        199      199           
Flag Coverage Δ
unittests 92.01% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/vsi.py 100.00% <100.00%> (ø)

@denproc denproc marked this pull request as ready for review March 29, 2023 23:03
@denproc denproc requested review from jzakirov and snk4tr March 29, 2023 23:03
Copy link
Contributor

@snk4tr snk4tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Less redundant computations is always welcome! GJ!

@snk4tr snk4tr merged commit 09aad9e into master Mar 30, 2023
@denproc denproc deleted the fix/optimise_meshgrid branch April 3, 2023 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Redundant mesh grid creation for VSI

2 participants