Skip to content

Move Constants to Module Buffer & Tests Update#364

Merged
denproc merged 10 commits intomasterfrom
fix/buffer_consts
Jun 9, 2023
Merged

Move Constants to Module Buffer & Tests Update#364
denproc merged 10 commits intomasterfrom
fix/buffer_consts

Conversation

@denproc
Copy link
Collaborator

@denproc denproc commented May 25, 2023

Closes #362
Closes #363

Proposed Changes

  • Change storage of scale_weights for MS-SSIM and MS-GMSD;
  • Update tests accordigly
  • Fix gradient propagation issues when CUDA used.

@codecov
Copy link

codecov bot commented May 25, 2023

Codecov Report

Merging #364 (af6b45f) into master (01e16b7) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #364   +/-   ##
=======================================
  Coverage   90.62%   90.63%           
=======================================
  Files          36       36           
  Lines        2869     2871    +2     
=======================================
+ Hits         2600     2602    +2     
  Misses        269      269           
Flag Coverage Δ
unittests 90.63% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
piq/gmsd.py 100.00% <100.00%> (ø)
piq/ms_ssim.py 100.00% <100.00%> (ø)

@denproc denproc requested review from jzakirov and snk4tr May 25, 2023 23:20
snk4tr
snk4tr previously approved these changes Jun 9, 2023
Copy link
Contributor

@snk4tr snk4tr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! Feel free to merge 👍

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jun 9, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@denproc denproc merged commit c26ce7c into master Jun 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tests fail for some metrics due to mismatch between tensor devices MS-SSIM error when running on GPU

2 participants