Fix issue with rewound response bodies #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When middleware returns an `HtmlResponse`, the body stream is typically rewound, with the pointer at position 0. Unfortunately, this means that any `write()` operations will *overwrite*! This patch does a check to see if the response is at `eof()`, and, if not and the response is seekable, sets the pointer to the end of the stream prior to writing.
snapshotpl
added a commit
that referenced
this pull request
Jan 7, 2016
Fix issue with rewound response bodies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When middleware returns an
HtmlResponse, the body stream is typically rewound, with the pointer at position 0. Unfortunately, this means that anywrite()operations will overwrite!This patch does a check to see if the response is at
eof(), and, if not and the response is seekable, sets the pointer to the end of the stream prior to writing.