Skip to content

Conversation

@alfsb
Copy link
Member

@alfsb alfsb commented Dec 12, 2024

Small cleanup before giving more love to configure.php.

Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MSTM

@alfsb
Copy link
Member Author

alfsb commented Dec 13, 2024

Ah, now CI passes. Merging.

Note to self: GitHub CI does not rebase for testing. It only test the branch as in it behind status. So CI testing does not automatically reflect the changes after merged, if the branch is behind master/HEAD.

@alfsb alfsb merged commit 7edcafd into php:master Dec 13, 2024
10 of 12 checks passed
@alfsb
Copy link
Member Author

alfsb commented Dec 13, 2024

This begs the question: Shouldn't CI scripts (locally) merge into HEAD before doing tests, doc-base and languages?

@alfsb alfsb deleted the rv1 branch December 13, 2024 10:12
@alfsb alfsb mentioned this pull request Dec 14, 2024
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants