Fix #76961: vote throws a Server Error over ipv6 #53
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes a bug when user with IPv6 is voting on a bug. It syncs the functionality with the rest of the ip column types in the database. Before applying this patch, the database schema need to be updated and current IPs should ideally be converted from integers to numeric values returned by the INET6_ATON() MySQL function.
Member
Author
|
This needs database schema to change first I think. Sending patch to the bugs.php.net instead and closing this one for now. |
Contributor
|
This could be the required live database change following suggested change in schema.sql alter table bugdb_votes modify ip varbinary(16) not null comment 'for ipv4 and ipv6'; |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes a bug when user with IPv6 is voting on a bug. It syncs the functionality with the rest of the ip column types in the database.
Before applying this patch, the database schema needs to be updated and current IPs should ideally be converted from integers to numeric values returned by the INET6_ATON() MySQL function.
Bug: https://bugs.php.net/bug.php?id=76961