-
-
Notifications
You must be signed in to change notification settings - Fork 130
Drop JSON output and allow update command without authentication #434
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is unclear to me how I should test the update mechanism so I mostly base this approval on reading the code and doing only very simple tests like ./padd.sh -v and ./padd.sh -u
Establishing connection with FTL...
Authentication successful.
PADD version is v4.0.0 (Latest: v4.0.0)
Session successfully deleted.
Establishing connection with FTL...
Authentication successful.
[✓] You are already using the latest PADD version v4.0.0
Session successfully deleted.
Maybe a follow-up PR can reduce the verbosity concerning API authentication here.
|
Conflicts have been resolved. |
|
I added a commit that allows to perform the update without login. I think there is no need to authenticate just to check/perform the update of this independent script. I also allowed to update in case PADD is running on docker (which was the only reason we used data from FTL and needed to login) - it will be overwritten on the next container creation, but why not? Testing the updater is simple: decrease the version number < 4.00 and run |
Signed-off-by: yubiuser <[email protected]>
…or that Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
Signed-off-by: yubiuser <[email protected]>
DL6ER
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested, works
What does this PR aim to accomplish?:
/etc/pihole/versionswhich does not exist when PADD is run remotely.By submitting this pull request, I confirm the following:
git rebase)