fix: make serializer::Error publicly available#5
Merged
pierd merged 1 commit intopierd:mainfrom Mar 16, 2026
Merged
Conversation
Owner
|
Thanks for the fix. I’m going to be away for a week - I'll have a look as soon as I'm back. |
Summary: When trying to but serializer::Error behind a thiserror's `[#from]` field it fails because the error is only `pub(crate)`, making it non nameable outside `maxminddb_writer`. By re-exporting it, it becomes visible and can let the users of the library handle the error more conveniently. Test Plan: `cargo test`
Contributor
Author
|
Thanks. In the meantime I forced-pushed the fmt fix. |
pierd
approved these changes
Mar 16, 2026
Owner
|
@chantra thanks for the fix. I've just published 0.1.2 version with your changes. |
Contributor
Author
|
Thanks @pierd ! |
Contributor
Author
|
seems the formatter failed . Sorry. |
Owner
No worries. That was an easy fix. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: When trying to but serializer::Error behind a thiserror's
[#from]field it fails because the error is onlypub(crate), making it non nameable outsidemaxminddb_writer.By re-exporting it, it becomes visible and can let the users of the library handle the error more conveniently.
Test Plan:
cargo test