Skip to content

Fixed: error TPM. Added: show current TPM#34

Merged
coocood merged 1 commit intopingcap:masterfrom
innerr:tpm-improv
Mar 29, 2020
Merged

Fixed: error TPM. Added: show current TPM#34
coocood merged 1 commit intopingcap:masterfrom
innerr:tpm-improv

Conversation

@innerr
Copy link
Copy Markdown
Contributor

@innerr innerr commented Mar 28, 2020

Signed-off-by: Liu Cong innerr@gmail.com

1, The TPM was not correct, especially happened on error TPM, it caused by the incorrect start-time of hist , this PR fixed that

2, This PR added a param --summary:

  • When it's true, print summary measurements on each tick
  • When it's false(by default), print current measurements on each tick, and print summary's on each 10 ticks

3, Print conflicted errors

Signed-off-by: Liu Cong <innerr@gmail.com>
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Mar 28, 2020

CLA assistant check
All committers have signed the CLA.

Copy link
Copy Markdown
Collaborator

@mahjonp mahjonp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, this problem I have also occurred before.

@coocood
Copy link
Copy Markdown
Member

coocood commented Mar 29, 2020

LGTM

@coocood coocood merged commit d65f05c into pingcap:master Mar 29, 2020
@innerr innerr deleted the tpm-improv branch March 30, 2020 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants