Add missing EnablePictureID in VP8Payloader#453
Open
vpalmisano wants to merge 1 commit intopion:mainfrom
Open
Conversation
The EnablePictureID param is required to create the extended RTP VP8 header. Without this header the VP8 streams cannot be Mediasoup SFU.
at-wat
reviewed
Nov 18, 2022
Member
at-wat
left a comment
at-wat
left a comment
There was a problem hiding this comment.
It's better to be configurable, but seems difficult on the current API.
I think having a global switch like
var VP8EnablePictureID = truewould be good for now.
Enabled by default should be fine.
Codecov ReportBase: 58.15% // Head: 58.15% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## master #453 +/- ##
=======================================
Coverage 58.15% 58.15%
=======================================
Files 62 62
Lines 3680 3680
=======================================
Hits 2140 2140
Misses 1413 1413
Partials 127 127 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The EnablePictureID param is required to create the extended RTP VP8 header. Without this header the VP8 streams cannot be read by the Mediasoup SFU.
Description
Reference issue