Change addresses to net.Addr #46
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emersion
force-pushed
the
header-addr
branch
2 times, most recently
from
7faced6 to
d640724
Compare
Contributor
Author
|
All done! This is ready for another review. |
pires
requested changes
Oct 26, 2020
Owner
pires
left a comment
pires
left a comment
There was a problem hiding this comment.
Overall LGTM but we're missing changes to README.md to reflect the breaking changes.
Also, I'll need a bit more time to review this properly.
Thank you very much for the work you've put into this 🤩
The motivation is to allow Header to hold Unix socket addresses.
Instead of using an IP and a port, use net.Addr, which allows to
represent any network address.
The Header.{Local,Remote}Addr methods are removed since users can now
just access Header.{Source,Destination}Addr.
New helpers (TCPAddrs, UDPAddrs, UnixAddrs, IPs, Ports) allows users to
easily extract data from the generic net.Addr fields.
Closes: pires#34
Closes: pires#43
Contributor
Author
Fixed
Sure, take your time :)
Thanks for maintaining this library! |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The motivation is to allow Header to hold Unix socket addresses.
Instead of using an IP and a port, use net.Addr, which allows to
represent any network address.
The Header.{Local,Remote}Addr methods are removed since users can now
just access Header.{Source,Destination}Addr.
New helpers (TCPAddrs, UDPAddrs, UnixAddrs, IPs, Ports) allows users to
easily extract data from the generic net.Addr fields.
Closes: #34
Closes: #43
Tests haven't been updated yet, but I'd like to gather some feedback because this is a quite radical change. What do you think?