Open
Conversation
Contributor
|
That's interesting @ed-fish were you getting 2d arrays written to disk before? Everything should be 1d in the pipeline... If you can say more about what led you to want to make this change, that would be helpful! |
Author
|
Oh yes you are correct! On second look I realised I created this error by using a dir with a mix of 1 and 2 dimensional vectors. Perhaps it is better addressed using an assert to ensure that if you use outputs from another model that they are 1d. Please feel free to reject the PR. |
Contributor
|
@ed-fish thanks for your follow up. An assertion that prints a useful message upon failure (e.g. Image vectors should be 1D but the image vectors found are 2D) would be a welcome PR instead if you like! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue where vector list cannot be cast to np array when loaded sequentially from cache.
Adds support for using both 2d and 1d cached vectors by expanding 1d vectors and stacking to ensure the correct shape.