Conversation
if one isn't specified in the config dict passed to iplot/plot
jonmmease
reviewed
Jun 15, 2019
plotly/offline/offline.py
Outdated
| plotly_platform_url = plotly.tools.get_config_plotly_server_url() | ||
|
|
||
| clean_config['plotlyServerURL'] = plotly_platform_url | ||
| if not clean_config.get('plotlyServerURL'): |
Contributor
There was a problem hiding this comment.
I think we want clean_config.get('plotlyServerURL', None) in case config doesn't include 'plotlyServerURL' at all.
jonmmease
suggested changes
Jun 15, 2019
Contributor
jonmmease
left a comment
jonmmease
left a comment
There was a problem hiding this comment.
Thanks for the fix @michaelbabyn, one comment above.
jonmmease
approved these changes
Jun 15, 2019
Contributor
|
Great, thanks @michaelbabyn! |
cs48a
pushed a commit
to cs48a/plotly.py
that referenced
this pull request
Jul 21, 2019
* only set plotlyServerURL using the plotly_domain in the .config file if one isn't specified in the config dict passed to iplot/plot * make it clear that the default in clean_config.get is None
nicolaskruchten
deleted the
check-config-passed-to-iplot-before-updating-plotlyServerURL
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This resolves #1609.
I tested this out locally using so that first example mentioned in the issue which didn't set the base url for the edit in chart studio button before the change does after.