docstring refactoring in figure factory#1837
Merged
emmanuelle merged 8 commits intomasterfrom Nov 11, 2019
Merged
Conversation
Contributor
Author
|
@nicolaskruchten @jonmmease ideally we would include this in the release, are you fine with this change (adding the |
Contributor
|
I’m fine with this whole class of change so feel free to merge these types of doc string PRs at will unless you’re concerned about something and want input! |
Contributor
Author
|
ok thanks! |
Contributor
|
looks great to me! 💃 |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Goals
iplot-->fig.show()Note that the
>>>do not prevent pasting in a notebook cell, jupyter know how to handle them.I'll work through the list of figure factories but I wanted to open this first as WIP for the sake of discussing this update.