Move imshow closer to px pattern#1885
Merged
nicolaskruchten merged 3 commits intomasterfrom Nov 8, 2019
Merged
Conversation
Contributor
Author
|
Here I've bolted on the applicable parts of the "defaults cascade" logic for which I added a test suite the other day :) |
Contributor
Author
|
This lets us do stuff like this:
|
emmanuelle
reviewed
Nov 8, 2019
Contributor
|
💃 when the CI is green. Which reminds me that we should add imshow examples to the percy test file, one with single-channel and one with RGB. If you don't want to add it here (I should have done this in the initial PR) I'll make another PR for this. |
Contributor
Author
|
Ah right yes... If you could do it that would be great :) |
Contributor
Author
|
Ah drat also we need to tweak the PR in py-docs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@emmanuelle here's the first pass on the PX-ification of the
imshowfunction. I'm realizing that to align better with the otherpxmethods we should probably addheight,widthandtemplateand the rest of thepxdefaulting machinery...