adding repo and branch options to updateplotlyjsdev#2349
adding repo and branch options to updateplotlyjsdev#2349nicolaskruchten merged 1 commit intoplotly:masterfrom
Conversation
ac834bb to
9c27404
Compare
|
looks like circle CI for 2.7 is failing (seems to be due to something unrelated to this PR though) |
|
Thank you very much for your PR @zouhairm ! The CI failure is indeed unrelated to your PR has just been fixed in master. You can merge master and push to be sure that everything is ok. |
|
So this is really a cool pull request. I just used your branch to build with a development branch currently developed in plotly.js, this is going to be so useful. The only thing I want to check before merging is that the PR modifies the name of the plotlyjs version, even in the case of plotly/master. I wonder if we have things in the repo depending on this name. All tests pass which is a good baseline. @jonmmease is it ok for you modifying the plotlyjs version name? It's also easy to slightly modify the PR so that it is not changed in the case plotly/master. |
|
Sounds good. Feel free to make the change or lmk and I can do it. |
|
This is a great change, thanks so much! |
PR to address #2344
Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).