px.NO_COLOR

[nicolaskruchten]

Code PR

• I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the codegen files and not generated files.
• I have added tests (if submitting a new feature or correcting a bug) or
  modified existing tests.
• For a new feature, I have added documentation examples in an existing or
  new tutorial notebook (please see the doc checklist as well).
• I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

[nicolaskruchten]

@emmanuelle the CI failure actually is material, and seems to be #2618

[nicolaskruchten]

(but not due to this PR as far as I can tell, so we should not consider it a PR blocker IMO)

[emmanuelle]

Looks good to me but we could add documentation examples:

import plotly.express as px
df = px.data.experiment(indexed=True)
fig = px.line(df, y=['experiment_1', 'experiment_2'], facet_row='variable', color=px.NO_COLOR)
fig.show()

for NO_COLOR, and an example in subplots.md for the spacing parameters. Do you want to add them here or to open an issue for this? Otherwise 💃

[nicolaskruchten]

I'll document the spacing params here. I already have one NO_COLOR doc example, do you think we need a second one?

[emmanuelle]

Sorry between the beginning and the end of the review I had forgotten about the NO_COLOR example :-).

Was it intentional to add px.timeline in the same PR?

[nicolaskruchten]

Yeah, although I probably should be a bit more disciplined. I added base to bar in this one too as prep for timeline

[nicolaskruchten]

OK, I've stripped out the bar base and timeline stuff into #2626

[nicolaskruchten]

still need a little bit of docs in this PR

[emmanuelle]

great example!

[emmanuelle]

💃 when CI is green (but 3.7-orca)