full_figure_for_development

[nicolaskruchten]

Addresses the non-error portion of #1967

@jonmmease I'm not sure how to best test this or if such a trivial function is worth a test... ?

[jonmmease]

Looks good, with one comment. As for testing, I think it would be worth adding a simple test under tests/test_optional (where kaleido is already installed for CI).

Just something simple that actually invokes kaleido and checks some expected default value.

[jonmmease]

Should probably refer to full_figure_for_development instead of Image export here

[nicolaskruchten]

thanks! done

[nicolaskruchten]

OK added a test and some docs!

[nicolaskruchten]

OK, all done! I had to add .decode("utf-8") to get bytes into strings for the Python 3.5 optional tests to pass ... normal? that'll work on 2.7 also right?

[nicolaskruchten]

also I added a doc page... feedback welcome :) @emmanuelle if you want to take a look that'd be cool too :)

[jonmmease]

OK, all done! I had to add .decode("utf-8") to get bytes into strings for the Python 3.5 optional tests to pass ... normal? that'll work on 2.7 also right?

Not sure about the Python 3.5 thing specifically, but decoding explicitly to utf-8 is the right thing to do.