Add Icicle Trace to Plotly.py#3139
Closed
Kully wants to merge 6 commits intoplotly:masterfrom
Kully:icicle-trace
Closed
Add Icicle Trace to Plotly.py#3139Kully wants to merge 6 commits intoplotly:masterfrom Kully:icicle-trace
Kully wants to merge 6 commits intoplotly:masterfrom
Kully:icicle-trace
Conversation
Contributor
|
Thanks! This is the right first commit to get this into the library, but I likely won't want to merge this PR alone: I would recommend that you build the PX support and docs into this PR, and I'll rebase and merge on top of master once Plotly.js 2.0 is released and Plotly.py is upgraded to use it. |
Contributor
Author
Sounds good. I am currently working on some basic docs right now. |
Merged
Contributor
|
Merged via cherry-pick. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code PR
plotly.graph_objects, my modifications concern thecodegenfiles and not generated files.modified existing tests.
new tutorial notebook (please see the doc checklist as well).
Other changes in this PR
setup.pyby changingpublishtopublish-dist. See this linecontributing.md