Remove not required build dependencies#5477
Conversation
To build plotly neither of the following dependencies are required: hatch, jupyter_packaging and wheel. Fixes plotly#5476 Signed-off-by: Francisco Redondo Marchena <fran.redondo@codethink.co.uk>
|
@camdecoster @emilykl , is there anything I can do to push this change forward? I have seen that only the optional tests are failing and I can not see a relation between the MR change and the issue reported on the optional tests. |
emilykl
left a comment
There was a problem hiding this comment.
Hi @franred! I apologize for the delay. I wanted to give you a big thanks for pointing out this issue -- you've led me down a larger rabbit hole of realizing that there's a number of config options in the pyproject.toml which are unused due to corresponding to the wrong build backend.
I'm now working on a larger PR to clean up the build process, but I don't see any problem with merging this change in the meantime. I've made one adjustment and I'm now waiting for the CI to pass again, will merge once that's complete.
Thanks!
|
Hi @emilykl , no worries! Looking forward for your new improvements on the build procress. Thanks! |
To build plotly neither of the following dependencies are required: hatch, jupyter_packaging and wheel.
Fixes #5476
Code PR
plotly.graph_objects, my modifications concern the code generator and not the generated files.I have added tests or modified existing tests.For a new feature, I have added documentation examples (please see the doc checklist as well).I have added a CHANGELOG entry if changing anything substantial.For a new feature or a change in behavior, I have updated the relevant docstrings in the code.