Skip to content

Remove not required build dependencies#5477

Merged
emilykl merged 3 commits intoplotly:mainfrom
franred:franred/remove-not-required-build-dependencies
Mar 12, 2026
Merged

Remove not required build dependencies#5477
emilykl merged 3 commits intoplotly:mainfrom
franred:franred/remove-not-required-build-dependencies

Conversation

@franred
Copy link
Contributor

@franred franred commented Jan 26, 2026

To build plotly neither of the following dependencies are required: hatch, jupyter_packaging and wheel.

Fixes #5476

Code PR

  • I have read through the contributing notes and understand the structure of the package. In particular, if my PR modifies code of plotly.graph_objects, my modifications concern the code generator and not the generated files.
  • I have added tests or modified existing tests.
  • For a new feature, I have added documentation examples (please see the doc checklist as well).
  • I have added a CHANGELOG entry if changing anything substantial.
  • For a new feature or a change in behavior, I have updated the relevant docstrings in the code.

To build plotly neither of the following dependencies are
required: hatch, jupyter_packaging and wheel.

Fixes plotly#5476

Signed-off-by: Francisco Redondo Marchena <fran.redondo@codethink.co.uk>
@franred
Copy link
Contributor Author

franred commented Mar 3, 2026

@camdecoster @emilykl , is there anything I can do to push this change forward? I have seen that only the optional tests are failing and I can not see a relation between the MR change and the issue reported on the optional tests.

Copy link
Contributor

@emilykl emilykl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @franred! I apologize for the delay. I wanted to give you a big thanks for pointing out this issue -- you've led me down a larger rabbit hole of realizing that there's a number of config options in the pyproject.toml which are unused due to corresponding to the wrong build backend.

I'm now working on a larger PR to clean up the build process, but I don't see any problem with merging this change in the meantime. I've made one adjustment and I'm now waiting for the CI to pass again, will merge once that's complete.

Thanks!

@franred
Copy link
Contributor Author

franred commented Mar 12, 2026

Hi @emilykl , no worries! Looking forward for your new improvements on the build procress. Thanks!

@emilykl emilykl merged commit d28f18e into plotly:main Mar 12, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

There are not-required dependencies defined in "build-system" "requires" field.

2 participants