This repository was archived by the owner on Aug 29, 2025. It is now read-only.
read colors from template #74
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolaskruchten
force-pushed
the
templates
branch
from
66588c9 to
9fef366
Compare
Contributor
Author
|
This PR now has |
jonmmease
reviewed
May 10, 2019
plotly_express/_core.py
Outdated
Contributor
There was a problem hiding this comment.
Is the idea here to catch a go.layout.Template object being passed in directly?
jonmmease
approved these changes
May 10, 2019
Contributor
jonmmease
left a comment
jonmmease
left a comment
There was a problem hiding this comment.
Looks good. Will be nice to have the styling logic more unified like this.
Contributor
Author
|
Thanks! This is a case where tests will be useful :) I’ll add an issue to unit test this function. |
nicolaskruchten
force-pushed
the
templates
branch
from
9fef366 to
f6b513f
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #70