Skip to content

fix(Outlines): use correct uniform type #2048

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CodyJasonBennett merged 1 commit into from
Jul 23, 2024
Merged

fix(Outlines): use correct uniform type #2048

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/core/Outlines.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ const OutlinesMaterial = /* @__PURE__ */ shaderMaterial(
#include <morphtarget_pars_vertex>
#include <skinning_pars_vertex>
uniform float thickness;
uniform float screenspace;
uniform bool screenspace;
uniform vec2 size;
void main() {
#if defined (USE_SKINNING)
Expand All @@ -37,7 +37,7 @@ const OutlinesMaterial = /* @__PURE__ */ shaderMaterial(
tNormal = instanceMatrix * tNormal;
tPosition = instanceMatrix * tPosition;
#endif
if (screenspace == 0.0) {
if (screenspace) {
vec3 newPosition = tPosition.xyz + tNormal.xyz * thickness;
gl_Position = projectionMatrix * modelViewMatrix * vec4(newPosition, 1.0);
} else {
Expand Down