feat(store2): add dev4_get_mounted_atoms#2594
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
Size Change: +141 B (+0.15%) Total Size: 92.1 kB
ℹ️ View Unchanged
|
|
| Playground | Link |
|---|---|
| React demo | https://livecodes.io?x=id/6KDNM2UJ2 |
See documentations for usage instructions.
dai-shi
reviewed
Jun 3, 2024
src/vanilla/store2.ts
Outdated
| // for debugging purpose only | ||
| type DevStoreRev4 = { | ||
| dev4_get_internal_weak_map: () => WeakMap<AnyAtom, AtomState> | ||
| dev4_get_mounted_atoms: () => IterableIterator<AnyAtom> |
Member
There was a problem hiding this comment.
I think it's fine to return the Set, given that our contract is it's read-only.
Suggested change
| dev4_get_mounted_atoms: () => IterableIterator<AnyAtom> | |
| dev4_get_mounted_atoms: () => Set<AnyAtom> |
dai-shi
approved these changes
Jun 3, 2024
Member
dai-shi
left a comment
dai-shi
left a comment
There was a problem hiding this comment.
LGTM! Thanks for working on this.
dai-shi
changed the title
dmaskasky
pushed a commit
to dmaskasky/jotai
that referenced
this pull request
Jun 7, 2024
* feat: add dev4_get_mounted_atoms * refactor: return a set from dev4_get_mounted_atoms --------- Co-authored-by: Daishi Kato <dai-shi@users.noreply.github.com>
This was referenced Sep 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dev4_get_mounted_atomsto return Iterable list of mounted atomsCheck List
pnpm run prettierfor formatting code and docs