Fix navigation title in BodyDetailView#162
Open
JeevanMahtani wants to merge 1 commit intopmusolino:masterfrom
Open
Fix navigation title in BodyDetailView#162JeevanMahtani wants to merge 1 commit intopmusolino:masterfrom
JeevanMahtani wants to merge 1 commit intopmusolino:masterfrom
Conversation
Owner
|
This should be dynamic, based on the point from which the screen is opened. When the response body is opened, we will have the same mismatch. |
pmusolino
requested changes
Jan 18, 2026
Owner
pmusolino
left a comment
pmusolino
left a comment
There was a problem hiding this comment.
Nice catch on the mislabeled body screen, but BodyDetailView is reused for both request + response. Hardcoding .navigationTitle("Request Body") will make the response-body screen incorrect. Can we parameterize the title (or pass an enum) and set it from the two NavigationLink call sites in RequestDetailView?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Quick PR to fix the navigation title as reported in #161