Skip to content
This repository was archived by the owner on Jan 19, 2021. It is now read-only.

Fix: Modern page text alignment issue#2469

Open
gautamdsheth wants to merge 1 commit intopnp:devfrom
gautamdsheth:modernPageFixAlignment
Open

Fix: Modern page text alignment issue#2469
gautamdsheth wants to merge 1 commit intopnp:devfrom
gautamdsheth:modernPageFixAlignment

Conversation

@gautamdsheth
Copy link
Copy Markdown
Contributor

Q A
Bug fix? yes
Related issues? fixes #2465

What's in this Pull Request?

Currently while extracting a modern page as well as provisioning a modern page, the text alignment was not correctly set as well as extracted. See issue #2465 . This PR fixes the issue by using the correct enum.

Currently while extracting a modern page as well as provisioning a modern page, the text alignment was not correctly set. See issue pnp#2465
@jansenbe jansenbe self-assigned this Nov 7, 2019
@jansenbe
Copy link
Copy Markdown
Contributor

jansenbe commented Nov 7, 2019

Nice catch @gautamdsheth . Given this impacts the existing templates (eg all our templates in the provisioning service) we need to coordinate patching the provisioning service and the templates aligned with processing this PR. I'll not merge this one for the November release due to above reasons, but we'll process it asap in the course of next week.

@roelwest
Copy link
Copy Markdown

Is it clear in which release this problem will be fixed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants