Implement auto skip to highlight/point of interest#71
Open
alopatindev wants to merge 2 commits intopo5:masterfrom
Open
Implement auto skip to highlight/point of interest#71alopatindev wants to merge 2 commits intopo5:masterfrom
alopatindev wants to merge 2 commits intopo5:masterfrom
Conversation
alopatindev
changed the title
alopatindev
force-pushed
the
add_poi_highlight_category
branch
from
845b3f4 to
981593f
Compare
alopatindev
force-pushed
the
add_poi_highlight_category
branch
from
981593f to
5a5aa4b
Compare
Obegg
approved these changes
Nov 26, 2023
Obegg
left a comment
Obegg
left a comment
There was a problem hiding this comment.
Tested on my machine and working fine, great PR :)
This comment was marked as resolved.
This comment was marked as resolved.
Author
|
Probably fixed, thanks! |
|
Thank you! Tested and working! |
|
@po5 Can you check this PR and merge it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I didn't test it well, specifically no idea whether it works correctly with
skip_once=yes.Perhaps it can be implemented even simpler way, without extra
mp.set_property("time-pos", t.end_time)call.I don't fully understand
skip_adsfunction, any edits/criticism are welcome.Videos for testing:
Closes #42