Conversation
UniquePanda
force-pushed
the
7-add-alternative-for-assignbrowseassigndrop-that-can-be-called-from-outside
branch
from
0520407 to
86d87a4
Compare
UniquePanda
force-pushed
the
7-add-alternative-for-assignbrowseassigndrop-that-can-be-called-from-outside
branch
from
86d87a4 to
cd3c33c
Compare
UniquePanda
force-pushed
the
7-add-alternative-for-assignbrowseassigndrop-that-can-be-called-from-outside
branch
from
cd3c33c to
1fa66e0
Compare
UniquePanda
force-pushed
the
7-add-alternative-for-assignbrowseassigndrop-that-can-be-called-from-outside
branch
from
1fa66e0 to
ecf6e32
Compare
UniquePanda
force-pushed
the
7-add-alternative-for-assignbrowseassigndrop-that-can-be-called-from-outside
branch
from
ecf6e32 to
133e9f0
Compare
adi64
reviewed
Mar 13, 2023
adi64
approved these changes
Mar 13, 2023
adi64
deleted the
7-add-alternative-for-assignbrowseassigndrop-that-can-be-called-from-outside
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge after #8
There actually already were two functions for exactly that purpose.
handleDropEventcan be called with an externalDragEventwhen a file was dropped somewhere.handleChangeEventcan be called with an externalInputEventwhen files were added to an input element.The only thing I had to change was to move some CSS handling from
handleDropEventinto an own function, so that this can still be done whenassignDropwas used, but is not always done whenhandleDropEventis called from the outside.Additionally I also did some minor changes tot he
test.html. This file is very barebones but maybe we can use it in the future and now it at least works again. 😄