-
Notifications
You must be signed in to change notification settings - Fork 33
[Persistence] Fix Persistence Module TODOs - Consolidate Postgres #149
Copy link
Copy link
Closed
Labels
coreCore infrastructure - protocol relatedCore infrastructure - protocol relatedpersistencePersistence specific changesPersistence specific changes
Milestone
Description
Objective
A general cleanup issue is needed to tackle TODO's and ensure the persistence module is usable/readable by consolidating PostgresContext and PostgresDb as part of #172.
Origin Document
Should follow issue-#128, issue-#105, issue-#147 and issue-#148 the persistence module is messier and more difficult to understand than the developers would want for organic external contribution.
Goals / Deliverables
- Run `log.
- Finish outstanding TODO's to ensure end-to-end functionality
- Consolidate
PostgresContextandPostgresDblike so:
type PostgresContext struct {
height int64
tx pgx.Tx
blockstore kvstore.KVStore
}- Avoid exposing
PostgresContextand/orPostgresDbfor testing purposes
General issue checklist
- Update the appropriate CHANGELOG
- Update the README
- If applicable, update the source code tree explanation
- If applicable, add or update a state, sequence or flowchart diagram using mermaid
- Update any relevant global documentation & references
- Document small issues / TODOs along the way
Creator: @andrewnguyen22
Co-creator: @Olshansk
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
coreCore infrastructure - protocol relatedCore infrastructure - protocol relatedpersistencePersistence specific changesPersistence specific changes
Type
Projects
Status
Done