-
Notifications
You must be signed in to change notification settings - Fork 33
[Code Structure] Follow protobuf enum best practices #258
Copy link
Copy link
Open
Labels
code healthNice to have code improvementNice to have code improvementcoreCore infrastructure - protocol relatedCore infrastructure - protocol related
Milestone
Description
Objective
Not following best practices for protobuf enum naming.
Origin Document
In #245, the following change was made:
In order to follow best practices, we should do the following:
Goals
- Change all existing protobuf enums to follow best practices
- Enforce best practices moving forward
Deliverable
- A single PR that converts existing protobufs (and their references) to follow best practices
- A single PR to update to update workflow to enforce best practices
Non-goals / Non-deliverables
- Changing any business logic in the codebase
General issue deliverables
- Update the appropriate CHANGELOG
- Update any relevant READMEs (local and/or global)
- Update any relevant global documentation & references
Testing Methodology
- All tests:
make test_all - LocalNet: verify a
LocalNetis still functioning correctly by following the instructions at docs/development/README.md
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
code healthNice to have code improvementNice to have code improvementcoreCore infrastructure - protocol relatedCore infrastructure - protocol related
Type
Projects
Status
Backlog

