Skip to content

[Code Structure] Follow protobuf enum best practices #258

@Olshansk

Description

@Olshansk

Objective

Not following best practices for protobuf enum naming.

Origin Document

In #245, the following change was made:

Screen Shot 2022-09-29 at 12 06 46 PM

In order to follow best practices, we should do the following:

Screen Shot 2022-09-29 at 12 08 20 PM

Goals

  • Change all existing protobuf enums to follow best practices
  • Enforce best practices moving forward

Deliverable

  • A single PR that converts existing protobufs (and their references) to follow best practices
  • A single PR to update to update workflow to enforce best practices

Non-goals / Non-deliverables

  • Changing any business logic in the codebase

General issue deliverables

  • Update the appropriate CHANGELOG
  • Update any relevant READMEs (local and/or global)
  • Update any relevant global documentation & references

Testing Methodology

  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @Olshansk
Co-Owners: @okdas + ?

Metadata

Metadata

Assignees

No one assigned

    Labels

    code healthNice to have code improvementcoreCore infrastructure - protocol related

    Type

    No type

    Projects

    Status

    Backlog

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions