[TECHDEBT] Change the `PersistenceRWContext` interface to pass `paramName` when getting a parameter

[andrewnguyen22]

Objective

Deprecate

• GetBlocksPerSession(height int64) (int, error)
  and
• GetServiceNodesPerSessionAt(height int64) (int, error)

for

• GetParameter(paramName string, height int64) (interface, error)

Origin Document

We genericized the param setters like:

SetParam(paramName string, value interface{}) error

We need a similar pattern for getters

Goals

• Lower code footprint,
• Remove placeholder constants
• Maintain a strict pattern

Deliverable

• Code complete implementation
• Updated documentation

General issue deliverables

• Update the appropriate CHANGELOG
• Update any relevant READMEs (local and/or global)
• Update any relevant global documentation & references
• If applicable, update the source code tree explanation
• If applicable, add or update a state, sequence or flowchart diagram using mermaid

---

Creator: @andrewnguyen22

[Olshansk]

Great starter task!

[Jasonyou1995]

I might need some help to get started (some super basic questions):

• Task questions
  • Do I need to implement the GetParameter function?
  • Should I comment out the two deprecated functions GetBlocksPerSession and GetServiceNodesPerSessionAt then combine them to GetParameter?
  • I saw the ./utility/context.go and ./persistence/module.go scripts are using this interface, should I update them all?
• Documentation questions
  • What is the specific documentation I should update other than CHANGELOG?

Thank you!

[Olshansk]

Do I need to implement the GetParameter function?

Yes.

Should I comment out the two deprecated functions GetBlocksPerSession and GetServiceNodesPerSessionAt then combine them to GetParameter?

Yes.

I saw the ./utility/context.go and ./persistence/module.go scripts are using this interface, should I update them all?

Yes.

What is the specific documentation I should update other than CHANGELOG?

For this change, since it's small. The changelog is enough.