[TECHDEBT][Shared] Address legacy Run golangci-lint errors

[jessicadaugherty]

Objective

Improve unit tests by addressing legacy linting errors

Origin Document

Raised by review of #235 (comment)

Goals

• Block PRs that break unit tests
• Block PRs that break linting errors
• Display code changes that do not follow style guidelines

Deliverables

• A PR that tends to all of the legacy linting errors in the repo
• A PR that updates the linting github workflow to block (rather than simply display a warning) on golang and repo linting errors

Non-goals / Non-deliverables

• Changing any business logic in the codebase

General issue deliverables

• Update the appropriate CHANGELOG
• Update any relevant READMEs (local and/or global)
• Update any relevant global documentation & references
• If applicable, update the source code tree explanation
• If applicable, add or update a state, sequence or flowchart diagram using mermaid

---

Creator: @jessicadaugherty
Co-Owners: @Olshansk

[Olshansk]

@jessicadaugherty Can we include this in iteration 4? It's a lower priority, but it blocks us from enabling the autolinters

[h5law]

@jessicadaugherty I'll do this (I don't know when iteration 4 is but can have it done this week). I find these errors annoying anyway so it'll be nice to get rid of em!

Just to confirm - fix the errors from the golanglint-ci test throughout the codebase and make the workflow blocking on failure?

[jessicadaugherty]

Amazing, thanks @h5law! I assigned this out to you on DeWork. LOL iteration 4 was in like October or something so this was originally a priority backlog item that kept getting refactored. Agreed it would improve contributor QoL! Appreciate it.

Just to confirm - fix the errors from the golanglint-ci test throughout the codebase and make the workflow blocking on failure?

Exactly! I'd take a look at the linked PR in "Origin Document" for more context on where we stumbled on this need. And, of course, lmk if you have any questions!