Objective
Design, consolidate & refactor how parameters unique to different actors are managed throughout the codebase.
Origin Document
At the time of writing this issue, persistence/test/setup_test.go has the following code snippet:

In #206, we consolidated some instances in the codebase where GenericParam and ActorSpecificParam are conflated, but the current definition for an actor does not make it clear what the "generic param" is:
message Actor {
ActorType actor_type = 1;
string address = 2;
string public_key = 3;
repeated string chains = 4;
string generic_param = 5;
string staked_amount = 6;
int64 paused_height = 7;
int64 unstaking_height = 8;
string output = 9;
}
For example, it could be a ServiceURI in the context of a ServiceNode or the MaxRelays count in the context of an App. Furthermore, it does not permit us to have more than one "actor specific parameter." This need to be cleared up and improved.
Goals
Deliverable
Non-goals / Non-deliverables
- Changing the parameter values associated with actors to actors
- Adding new functionality
- Refactoring unrelated parts of the codebase
General issue deliverables
Testing Methodology
- All tests:
make develop_all
- LocalNet: verify a
LocalNet is still functioning correctly by following the instructions at docs/development/README.md
Creator: @Olshansk
Co-Owners: @andrewnguyen22
Objective
Design, consolidate & refactor how parameters unique to different actors are managed throughout the codebase.
Origin Document
At the time of writing this issue,
persistence/test/setup_test.gohas the following code snippet:In #206, we consolidated some instances in the codebase where
GenericParamandActorSpecificParamare conflated, but the current definition for an actor does not make it clear what the "generic param" is:For example, it could be a
ServiceURIin the context of aServiceNodeor theMaxRelayscount in the context of anApp. Furthermore, it does not permit us to have more than one "actor specific parameter." This need to be cleared up and improved.Goals
Deliverable
Non-goals / Non-deliverables
General issue deliverables
Testing Methodology
make develop_allLocalNetis still functioning correctly by following the instructions at docs/development/README.mdCreator: @Olshansk
Co-Owners: @andrewnguyen22