[P2P] Add contexts to method signatures

[bryanchriswhite]

Objective

Add context.Context arguments to all method signatures requiring downstream context and push context creation up the call stack as high as possible to align with Go conventions and best practices, and support future distributed tracing efforts.

Origin Document

... (lost)

Goals

• Align context.Context usage with go conventions / best practices
• Support future distributed tracing efforts ([Telemetry] Distributed Tracing in a V1 Node #143)
  • We will likely need fairly ubiquitous access to context objects everywhere we want to measure

Deliverable

• Add context.Context arguments to all method signatures which require a context downstream (at least).
• Push context creation up the call stack as high as possible / reasonable (i.e. context.Background()).

Non-goals / Non-deliverables

• Refactoring, simplifying or otherwise changing method signatures outside the scope of passing context.Contexts.

General issue deliverables

• Update the appropriate CHANGELOG(s)
• Update any relevant local/global README(s)
• Update relevant source code tree explanations
• Add or update any relevant or supporting mermaid diagrams

Testing Methodology

• Task specific tests or benchmarks: make ...
• New tests or benchmarks: make ...
• All tests: make test_all
• LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

---

Creator: @bryanchriswhite

[Olshansk]

@bryanchriswhite NIT on how you put together the github description:

Objective: A one line tl;dr for everyone.
For example: Propagate golan'g context.Context through the p2p module

Goals:: Bullet points of what the outcome will be.
For example:

• Ability to access, propagate and attach a context to all functions ...
• Push context creation up the call stack as high as possible / reasonable (i.e. context.Background()).

Deliverables: The actual work that will be done
For example:

• Add context.Context as an argument to all method signatures which require a context downstream (at least).

Assuming that makes sense, are you open to updating the GitHub template to make it more obvious?

[bryanchriswhite]

@Olshansk thanks for the pointers! 🙌

My main focus at the time of writing was to get an issue number to put in a comment. but of course, I'm more than happy to clean it up. 😅 I figured applying the triage label would make it clear that it needs improvement before it is actionable.