-
Notifications
You must be signed in to change notification settings - Fork 33
[P2P] Host/port shouldn't be required in client debug mode #678
Copy link
Copy link
Open
Labels
bugSomething isn't working - expected behaviour is incorrectSomething isn't working - expected behaviour is incorrectcommunityOpen to or owned by a non-core team memberOpen to or owned by a non-core team membercore starter taskGood for newcomers, but aimed at core team members though still open for everyoneGood for newcomers, but aimed at core team members though still open for everyonep2pP2P specific changesP2P specific changestriageIt requires some decision-making at team level (it can't be worked on as it stands)It requires some decision-making at team level (it can't be worked on as it stands)
Milestone
Description
Objective
Improve user experience of the debug CLI.
Origin Document
Goals
- Debug CLI command is usable when
hostnameandportP2P config fields are absent or empty string
Deliverable
- Update P2P module
#Create()logic to setm.listenAddrs = libp2p.NoListenAddrsifisClientDebugMode(regardless of `m.cfg.ConnectionType) - Remove
POCKET_P2P_HOSTNAMEenv var fromcli-client.yamlmanifest - Fix resulting or related bugs and/or errors
Non-goals / Non-deliverables
- Modifying the P2P config
- Modifying
Networkimplementations
General issue deliverables
- Update the appropriate CHANGELOG(s)
- Update any relevant local/global README(s)
- Update relevant source code tree explanations
- Add or update any relevant or supporting mermaid diagrams
Testing Methodology
TODO
- All tests:
make test_all - LocalNet: verify a
LocalNetis still functioning correctly by following the instructions at docs/development/README.md - *k8s LocalNet: verify a
k8s LocalNetis still functioning correctly by following the instructions here
Creator: [github username of the creator]
Co-Owners: [optional - github usernames of the co-owner(s)]
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
bugSomething isn't working - expected behaviour is incorrectSomething isn't working - expected behaviour is incorrectcommunityOpen to or owned by a non-core team memberOpen to or owned by a non-core team membercore starter taskGood for newcomers, but aimed at core team members though still open for everyoneGood for newcomers, but aimed at core team members though still open for everyonep2pP2P specific changesP2P specific changestriageIt requires some decision-making at team level (it can't be worked on as it stands)It requires some decision-making at team level (it can't be worked on as it stands)
Type
Projects
Status
Up Next
