Skip to content

[CI] Add inline error check linter#770

Merged
okdas merged 2 commits intomainfrom
chore/linter-inline-errcheck
May 18, 2023
Merged

[CI] Add inline error check linter#770
okdas merged 2 commits intomainfrom
chore/linter-inline-errcheck

Conversation

@okdas
Copy link
Copy Markdown
Contributor

@okdas okdas commented May 18, 2023

Description

Enhances the linter for inline error checks and alters existing error checks to be inline.

Type of change

Please mark the relevant option(s):

  • Code health or cleanup

List of changes

  • Introduces new custom linter
  • Changes existing code to be compliant with new linter rule

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@okdas okdas added the infra Core infrastructure - not protocol related label May 18, 2023
@okdas okdas self-assigned this May 18, 2023
@reviewpad reviewpad bot added the small Pull request is small label May 18, 2023
@okdas okdas marked this pull request as ready for review May 18, 2023 20:30
@okdas
Copy link
Copy Markdown
Contributor Author

okdas commented May 18, 2023

Because the change is so small, I didn't add a changelog and only validated it with make develop_test, but let me know if you want me to do more testing.

@okdas okdas requested a review from Olshansk May 18, 2023 20:32
@okdas okdas added the gpt review Triggers a code review from https://github.com/anc95/ChatGPT-CodeReview label May 18, 2023
@Olshansk
Copy link
Copy Markdown
Collaborator

Because the change is so small, I didn't add a changelog and only validated it with make develop_test, but let me know if you want me to do more testing.

Completely agreed. Please do still add the iteration & project. It helps us track the work at the end of the sprint

@okdas okdas merged commit 97ca32e into main May 18, 2023
@okdas okdas deleted the chore/linter-inline-errcheck branch May 18, 2023 21:06
okdas added a commit that referenced this pull request May 19, 2023
## Description

Enhances the linter for inline error checks and alters existing error
checks to be inline.

## Type of change

Please mark the relevant option(s):

- [x] Code health or cleanup

## List of changes

- Introduces new custom linter
- Changes existing code to be compliant with new linter rule

## Testing

- [x] `make develop_test`; if any code changes were made
- [ ] `make test_e2e` on [k8s
LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
if any code changes were made
- [ ] `e2e-devnet-test` passes tests on
[DevNet](https://pocketnetwork.notion.site/How-to-DevNet-ff1598f27efe44c09f34e2aa0051f0dd);
if any code was changed
- [ ] [Docker Compose
LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md);
if any major functionality was changed or introduced
- [ ] [k8s
LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
if any infrastructure or configuration changes were made

## Required Checklist

- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added, or updated, [`godoc` format
comments](https://go.dev/blog/godoc) on touched members (see:
[tip.golang.org/doc/comment](https://tip.golang.org/doc/comment))
- [ ] I have tested my changes using the available tooling
- [ ] I have updated the corresponding CHANGELOG

### If Applicable Checklist

- [ ] I have updated the corresponding README(s); local and/or global
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added, or updated,
[mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding
README(s)
- [ ] I have added, or updated, documentation and
[mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*`
if I updated `shared/*`README(s)
Olshansk pushed a commit that referenced this pull request May 24, 2023
## Description

Enhances the linter for inline error checks and alters existing error
checks to be inline.

## Type of change

Please mark the relevant option(s):

- [x] Code health or cleanup

## List of changes

- Introduces new custom linter
- Changes existing code to be compliant with new linter rule

## Testing

- [x] `make develop_test`; if any code changes were made
- [ ] `make test_e2e` on [k8s
LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
if any code changes were made
- [ ] `e2e-devnet-test` passes tests on
[DevNet](https://pocketnetwork.notion.site/How-to-DevNet-ff1598f27efe44c09f34e2aa0051f0dd);
if any code was changed
- [ ] [Docker Compose
LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md);
if any major functionality was changed or introduced
- [ ] [k8s
LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md);
if any infrastructure or configuration changes were made

## Required Checklist

- [x] I have performed a self-review of my own code
- [ ] I have commented my code, particularly in hard-to-understand areas
- [ ] I have added, or updated, [`godoc` format
comments](https://go.dev/blog/godoc) on touched members (see:
[tip.golang.org/doc/comment](https://tip.golang.org/doc/comment))
- [ ] I have tested my changes using the available tooling
- [ ] I have updated the corresponding CHANGELOG

### If Applicable Checklist

- [ ] I have updated the corresponding README(s); local and/or global
- [ ] I have added tests that prove my fix is effective or that my
feature works
- [ ] I have added, or updated,
[mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding
README(s)
- [ ] I have added, or updated, documentation and
[mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*`
if I updated `shared/*`README(s)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gpt review Triggers a code review from https://github.com/anc95/ChatGPT-CodeReview infra Core infrastructure - not protocol related small Pull request is small waiting-for-review

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants