chore: add --build-tags flag to go_lint make target#807
Merged
bryanchriswhite merged 1 commit intomainfrom Jun 8, 2023
Merged
Conversation
bryanchriswhite
added
bug
Olshansk
approved these changes
Jun 7, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Jun 8, 2023
## Description Add missing `--build-tags` flag to the `go_lint` makefile target. <!-- reviewpad:summarize:start --> ### Summary generated by Reviewpad on 07 Jun 23 09:07 UTC This pull request adds a `--build-tags` flag to the `go_lint` make target, allowing developers to run linters for specific build tags. The patch enables the test tag during the linting process. <!-- reviewpad:summarize:end --> ## Issue N/A ## Type of change Please mark the relevant option(s): - [ ] New feature, functionality or library - [x] Bug fix - [x] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other <!-- add details here if it a different type of change --> ## List of changes - Added `--build-tags "test"` to `go_lint` makefile target ## Testing - [ ] `make develop_test`; if any code changes were made - [ ] `make test_e2e` on [k8s LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md); if any code changes were made - [ ] `e2e-devnet-test` passes tests on [DevNet](https://pocketnetwork.notion.site/How-to-DevNet-ff1598f27efe44c09f34e2aa0051f0dd); if any code was changed - [ ] [Docker Compose LocalNet](https://github.com/pokt-network/pocket/blob/main/docs/development/README.md); if any major functionality was changed or introduced - [ ] [k8s LocalNet](https://github.com/pokt-network/pocket/blob/main/build/localnet/README.md); if any infrastructure or configuration changes were made ## Required Checklist - [ ] I have performed a self-review of my own code - [ ] I have commented my code, particularly in hard-to-understand areas - [ ] I have added, or updated, [`godoc` format comments](https://go.dev/blog/godoc) on touched members (see: [tip.golang.org/doc/comment](https://tip.golang.org/doc/comment)) - [ ] I have tested my changes using the available tooling - [ ] I have updated the corresponding CHANGELOG ### If Applicable Checklist - [ ] I have updated the corresponding README(s); local and/or global - [ ] I have added tests that prove my fix is effective or that my feature works - [ ] I have added, or updated, [mermaid.js](https://mermaid-js.github.io) diagrams in the corresponding README(s) - [ ] I have added, or updated, documentation and [mermaid.js](https://mermaid-js.github.io) diagrams in `shared/docs/*` if I updated `shared/*`README(s)
bryanchriswhite
added a commit
that referenced
this pull request
Jun 8, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Jun 8, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Jun 8, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Jun 8, 2023
bryanchriswhite
added a commit
that referenced
this pull request
Jun 8, 2023
* refactor/peerstore-provider: (22 commits) fix: bugs chore: update changelogs refactor: rename `T` & `K` type params to `M` &`C` chore: improve comment chore: add issue numbers to TECHDEBT comments chore: add TECHDEBT comments refactor: re-implement `GetUnstakedPeerstore` refactor: update peerstore provider method receivers refactor: `p2pPeerstoreProvider` to a single function' refactor: rename persistence.go back to provider.go refactor: consolidate p2pPeerstoreProvider into persistencePeerstorProvider chore: oneline function signature refactor: embed `p2pPStoreProviderFactory` refactor: persistence peerstor provider Consensus/readme (#777) chore: add `--build-tags` flag to `go_lint` make target (#807) [Core] Deploying all-the-protocol-actors (#710) fix: retrieve p2p mdoule from bus on each call chore: add godoc comments chore: remove unused `GetP2PConfig()` method ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add missing
--build-tagsflag to thego_lintmakefile target.Summary generated by Reviewpad on 07 Jun 23 09:07 UTC
This pull request adds a
--build-tagsflag to thego_lintmake target, allowing developers to run linters for specific build tags. The patch enables the test tag during the linting process.Issue
N/A
Type of change
Please mark the relevant option(s):
List of changes
--build-tags "test"togo_lintmakefile targetTesting
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)