[Persistence][Bug] Fix Actor Schema Assignment for ValidatorActor in GetActor#857
Merged
Olshansk merged 1 commit intopokt-network:mainfrom Jul 3, 2023
Merged
Conversation
During a review of the GetActor function in actor.go, it is found that the schema for types.ValidatorActor.GetActorType() was incorrectly set to types.FishermanActor. This commit corrects this issue by ensuring that the schema assignment for types.ValidatorActor.GetActorType() is indeed types.ValidatorActor.
Olshansk
approved these changes
Jun 26, 2023
Olshansk
pushed a commit
that referenced
this pull request
Jul 5, 2023
…GetActor (#857) ## Issue: An issue was discovered in the `GetActor` function defined in `actor.go`. Specifically, when the `actorType` input argument matches with `types.ValidatorActor.GetActorType()`, the `schema` variable is currently assigned as `types.FishermanActor`. This appears to be a typo or error, as logically `schema` should be assigned `types.ValidatorActor` in this case. This could potentially cause `GetActor` to behave unexpectedly when called with `types.ValidatorActor.GetActorType()` as it would process as if it were `types.FishermanActor.GetActorType()`. ## Proposed Fix: This pull request corrects the `schema` assignment for `types.ValidatorActor.GetActorType()` from `types.FishermanActor` to `types.ValidatorActor`, thus aligning the function behavior with the expected logic. ## Type of change Please mark the relevant option(s): - [ ] New feature, functionality or library - [x] Bug fix - [ ] Code health or cleanup - [ ] Major breaking change - [ ] Documentation - [ ] Other <!-- add details here if it a different type of change -->
bryanchriswhite
added a commit
that referenced
this pull request
Jul 7, 2023
* pokt/main: [Utility] Update E2E feature path template doc (#870) [IBC] Add nil check on proof for membership and non-membership proof creation (#877) Added git diff state to devlog10 Devlog 10 (#872) [Documentation] Add IBC Module introduction as an example (#853) [Persistence][Bug] Fix Actor Schema Assignment for ValidatorActor in GetActor (#857) QOL: add bash completion for p1 to localnet client (#865)
bryanchriswhite
added a commit
that referenced
this pull request
Jul 7, 2023
* feat/integrate-bg-router: fix: goimports fix: unstaked actor bootstrapping FSM transition chore: add error log test: improve background router validation test docs: fix mistake in peer discovery section [Utility] Update E2E feature path template doc (#870) [IBC] Add nil check on proof for membership and non-membership proof creation (#877) Added git diff state to devlog10 Devlog 10 (#872) [Documentation] Add IBC Module introduction as an example (#853) [Persistence][Bug] Fix Actor Schema Assignment for ValidatorActor in GetActor (#857) QOL: add bash completion for p1 to localnet client (#865)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue:
An issue was discovered in the
GetActorfunction defined inactor.go. Specifically, when theactorTypeinput argument matches withtypes.ValidatorActor.GetActorType(), theschemavariable is currently assigned astypes.FishermanActor. This appears to be a typo or error, as logicallyschemashould be assignedtypes.ValidatorActorin this case. This could potentially causeGetActorto behave unexpectedly when called withtypes.ValidatorActor.GetActorType()as it would process as if it weretypes.FishermanActor.GetActorType().Proposed Fix:
This pull request corrects the
schemaassignment fortypes.ValidatorActor.GetActorType()fromtypes.FishermanActortotypes.ValidatorActor, thus aligning the function behavior with the expected logic.Type of change
Please mark the relevant option(s):