Conversation
Olshansk
reviewed
Jul 11, 2023
Collaborator
Olshansk
left a comment
There was a problem hiding this comment.
A few minor comments & nits here and there but overall, this is 🧹 and 💅
Olshansk
requested changes
Jul 11, 2023
Collaborator
Olshansk
left a comment
There was a problem hiding this comment.
A few minor comments & nits here and there but overall, this is 🧹 and 💅
Olshansk
approved these changes
Jul 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Summary generated by Reviewpad on 13 Jul 23 12:29 UTC
This pull request introduces several changes across multiple files. Here is a summary of the diff:
benchmark_state_test.go, a slice ofuint8is modified to generate a random value using therand.Intnfunction, preventing duplicate keys.persistence_module.go, new methodsSetIBCEventandGetIBCEventsare added to enhance the persistence module's functionality for handling IBC events.SetIBCEventandGetIBCEventsare added for storing and retrieving IBC events at a specific height and topic.persistence/types/ibc.go, multiple changes include adding constants, new functions for generating queries, renaming a function, and modifying existing functions for handling IBC events and entries.bus.go, a new functionGetEventLoggeris added to thebusstruct, returning a value of typemodules.EventLogger.Create()function in theibc/hostpackage.ibc_test.go, there are modifications to test functions, adding new test functions, and adding anattributestruct.ibc_event_module.gois added, defining a package, imports, constants, types, and methods related to an event logging system.bus_module.goshow the addition of a new methodGetEventLoggerto theBusinterface.persistence/debug.go, functionsClearAllIBCQuery,ClearAllIBCStoreQuery, andClearAllIBCEventsQueryare added/removed, and a modification is made to theHandleDebugMessagefunction signature.event_manager.gois added, containing the definition of theEventManagerstruct and implementing theEventLoggerinterface.ics24.mdintroduce a new section for an event logging system in the IBC module, with an overview of its implementation and usage of a persistence layer.ibc_events.protois added, defining message types for attributes and IBC events in the shared/core/types/proto directory.These changes aim to introduce and enhance functionality related to IBC events, event logging, and persistence in the project.
Issue
Fixes #824
Type of change
Please mark the relevant option(s):
List of changes
EventLoggerinterface and submoduleIBCEventprotobuf typeEventLoggerto the bus for retrievalTesting
make develop_test; if any code changes were mademake test_e2eon k8s LocalNet; if any code changes were madee2e-devnet-testpasses tests on DevNet; if any code was changedRequired Checklist
godocformat comments on touched members (see: tip.golang.org/doc/comment)If Applicable Checklist
shared/docs/*if I updatedshared/*README(s)