Skip to content

[WIP][Persistence] Adds save and load CLI functions#946

Closed
dylanlott wants to merge 12 commits intopersistence/save-loadfrom
persistence/save-load-cli
Closed

[WIP][Persistence] Adds save and load CLI functions#946
dylanlott wants to merge 12 commits intopersistence/save-loadfrom
persistence/save-load-cli

Conversation

@dylanlott
Copy link
Copy Markdown
Contributor

Description

Adds the CLI for treeStore save and load functionality.

Issue

Fixes #

Type of change

Please mark the relevant option(s):

  • New feature, functionality or library
  • Bug fix
  • Code health or cleanup
  • Major breaking change
  • Documentation
  • Other

List of changes

Testing

  • make develop_test; if any code changes were made
  • make test_e2e on k8s LocalNet; if any code changes were made
  • e2e-devnet-test passes tests on DevNet; if any code was changed
  • Docker Compose LocalNet; if any major functionality was changed or introduced
  • k8s LocalNet; if any infrastructure or configuration changes were made

Required Checklist

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added, or updated, godoc format comments on touched members (see: tip.golang.org/doc/comment)
  • I have tested my changes using the available tooling
  • I have updated the corresponding CHANGELOG

If Applicable Checklist

  • I have updated the corresponding README(s); local and/or global
  • I have added tests that prove my fix is effective or that my feature works
  • I have added, or updated, mermaid.js diagrams in the corresponding README(s)
  • I have added, or updated, documentation and mermaid.js diagrams in shared/docs/* if I updated shared/*README(s)

@Olshansk
Copy link
Copy Markdown
Collaborator

@dylanlott Should this be a draft or ready for review?

@dylanlott dylanlott force-pushed the persistence/save-load-cli branch from 0a850a0 to 8715d36 Compare July 29, 2023 01:50
@dylanlott dylanlott marked this pull request as draft July 29, 2023 01:51
@dylanlott dylanlott changed the base branch from persistence/savepoints-initial to persistence/save-load July 29, 2023 01:52
@reviewpad reviewpad bot added medium Pull request is medium and removed large Pull request is large labels Jul 29, 2023
@dylanlott dylanlott force-pushed the persistence/save-load branch from ec24322 to 0c6e894 Compare July 31, 2023 20:37
@reviewpad reviewpad bot added large Pull request is large and removed medium Pull request is medium labels Jul 31, 2023
@dylanlott dylanlott force-pushed the persistence/save-load branch from 7f3d341 to 2c6fb5c Compare August 1, 2023 02:19
@dylanlott dylanlott force-pushed the persistence/save-load-cli branch from 8074414 to 8263572 Compare August 1, 2023 18:42
@reviewpad reviewpad bot added medium Pull request is medium large Pull request is large and removed large Pull request is large medium Pull request is medium labels Aug 1, 2023
@dylanlott dylanlott force-pushed the persistence/save-load-cli branch from 63de922 to 02b2242 Compare August 7, 2023 22:22
@dylanlott dylanlott force-pushed the persistence/save-load-cli branch from 37d879d to a55b46d Compare August 8, 2023 20:41
@dylanlott dylanlott force-pushed the persistence/save-load-cli branch from a55b46d to 9c75f0e Compare August 8, 2023 21:02
@dylanlott dylanlott closed this Jul 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

large Pull request is large

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

2 participants