[Morse -> Shannon Migration] account import & claim E2E tests (part 1)#1133
Merged
bryanchriswhite merged 72 commits intomainfrom Apr 2, 2025
Merged
[Morse -> Shannon Migration] account import & claim E2E tests (part 1)#1133bryanchriswhite merged 72 commits intomainfrom
bryanchriswhite merged 72 commits intomainfrom
Conversation
bryanchriswhite
added
testing
bryanchriswhite
force-pushed
the
issues/1034/test/e2e
branch
from
8d25d5f to
0ffcb37
Compare
bryanchriswhite
commented
Mar 18, 2025
bryanchriswhite
commented
Mar 18, 2025
bryanchriswhite
commented
Mar 18, 2025
bryanchriswhite
commented
Mar 18, 2025
bryanchriswhite
changed the base branch from
issues/1034/cli/claim_account
to
issues/1034/cli/import
bryanchriswhite
force-pushed
the
issues/1034/test/e2e
branch
from
0ffcb37 to
1effc89
Compare
bryanchriswhite
changed the title
bryanchriswhite
added
the
tooling
bryanchriswhite
changed the title
12 tasks
bryanchriswhite
force-pushed
the
issues/1034/cli/import
branch
from
155905c to
27509dc
Compare
bryanchriswhite
force-pushed
the
issues/1034/test/e2e
branch
from
1effc89 to
6eacb97
Compare
(cherry picked from commit 04e632861eb5529640b0cffcbd42d47409c6c799)
bryanchriswhite
modified the milestones:
Beta TestNet Iteration,
Morse to Shannon Migration
Olshansk
approved these changes
Apr 1, 2025
Collaborator
Olshansk
left a comment
Olshansk
left a comment
There was a problem hiding this comment.
@bryanchriswhite Approving in order to get the merge train moving.
-
PTAL at my last commit here:
e59090b(#1133). It has UNTESTED nits & edits. -
Once we get things merged in, I'm sure we'll find issues, so I'm delaying that investigation since this is "good enough" for now.
Let's push through!
bryanchriswhite
added a commit
that referenced
this pull request
Apr 2, 2025
## Summary ### NOTE: @Reviewer, E2E test coverage is included in #1133 ```bash $ poktrolld tx migration claim-account ./pocket-account-8b257c7f4e884e49bafc540d874f33f91436e1dc.json --from app1 Enter Decrypt Passphrase: MsgClaimMorseAccount { "shannon_dest_address": "pokt1mrqt5f7qh8uxs27cjm9t7v9e74a9vvdnq5jva4", "morse_src_address": "8B257C7F4E884E49BAFC540D874F33F91436E1DC", "morse_signature": "hLGhLRjP6jgP6wgOIaYFxIxT3z4jb4IBDKovMkX5AqUsOqdF+rEIO5aofOKnmYW9BkqL0v2DfUfE3nj25FNhBA==" } Confirm MsgClaimMorseAccount: y/[n]: ``` Changes: - Refactor existing `migrate` cmd code to be more consistent with cosmos-sdk conventions. - Add `migrate claim-account` sub-cmd fof executing `MsgClaimMorseAccount`s on-chain. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [ ] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [ ] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com> Co-authored-by: red-0ne <red-0ne@users.noreply.github.com>
* pokt/main: [Morse->Shannon Migration] CLI: claim Morse account (#1105)
bryanchriswhite
added a commit
that referenced
this pull request
Apr 2, 2025
…1132) ## Summary ### NOTE: @Reviewer, E2E test coverage is included in #1133 ```shell Import the Morse accounts contained within the Morse account state JSON file. The Morse account state JSON can be generated by transforming the "Morse state export". See: `pocket util export-genesis-for-reset -h` and `poktrolld tx migration collect-morse-accounts`. This will construct, sign, and broadcast a tx containing a MsgImportMorseClaimableAccounts message. See: https://dev.poktroll.com/operate/morse_migration/overview.md for more information. Usage: pocketd tx migration import-morse-accounts [morse-account-state-json-path] [flags] ``` Changes: - Add logging to `MsgImportMorseClaimableAccounts` handler. - Add `pocketd tx migration import-morse-accounts` CLI sub-command. ## Issue - Issue: #1034 ## Type of change Select one or more from the following: - [x] New feature, functionality or library - [ ] Consensus breaking; add the `consensus-breaking` label if so. See #791 for details - [ ] Bug fix - [ ] Code health or cleanup - [ ] Documentation - [ ] Other (specify) ## Sanity Checklist - [x] I have updated the GitHub Issue `assignees`, `reviewers`, `labels`, `project`, `iteration` and `milestone` - [ ] For docs, I have run `make docusaurus_start` - [x] For code, I have run `make go_develop_and_test` and `make test_e2e` - [ ] For code, I have added the `devnet-test-e2e` label to run E2E tests in CI - [ ] For configurations, I have update the documentation - [ ] I added TODOs where applicable --------- Co-authored-by: Daniel Olshansky <olshansky.daniel@gmail.com> Co-authored-by: Redouane Lakrache <r3d0ne@gmail.com> Co-authored-by: red-0ne <red-0ne@users.noreply.github.com>
* pokt/main: [Morse -> Shannon Migration] Authority CLI: `import-morse-accounts` (#1132)
bryanchriswhite
added a commit
that referenced
this pull request
Apr 2, 2025
* pokt/main: [Morse -> Shannon Migration] account import & claim E2E tests (part 1) (#1133)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
E2E test coverage for migration module importing and claiming of Morse accounts.
Implemented coverage:
pocketd tx migration collect-morse-accounts ...pocketd tx migration import-morse-accounts ...pocketd tx migration claim-account ...Pending coverage:
pocketd tx migration claim-application ...(covered in [Morse -> Shannon Migration] CLI: claim Morse application #1148)pocketd tx migration claim-supplier ...pocketd tx migration validate-morse-accounts ...Issue
Type of change
Select one or more from the following:
consensus-breakinglabel if so. See [Infra] Automatically add theconsensus-breakinglabel #791 for detailsSanity Checklist
assignees,reviewers,labels,project,iterationandmilestonemake docusaurus_startmake go_develop_and_testandmake test_e2edevnet-test-e2elabel to run E2E tests in CI