[Review] Review of #1262: [IBC] Prepare pocket for IBC connectivity#1624
[Review] Review of #1262: [IBC] Prepare pocket for IBC connectivity#1624bryanchriswhite merged 1 commit intochore/ibcfrom
[IBC] Prepare pocket for IBC connectivity#1624Conversation
| ibcConnectionParams := connectiontypes.Params{ | ||
| MaxExpectedTimePerBlock: uint64(ibcConnectionParamMaxExpectedTimePerBlock.Nanoseconds()), | ||
| } | ||
| // TODO_IN_THIS_PR: Replace fmt.Printf with proper logging |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
| Timestamp: uint64(ibcChannelParamUpgradeTimeoutTimestamp.Nanoseconds()), | ||
| }, | ||
| } | ||
| // TODO_IN_THIS_PR: Replace fmt.Printf with proper logging |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
| ibcClientParams := ibcclienttypes.Params{ | ||
| AllowedClients: IbcClientParamAllowedClients, | ||
| } | ||
| // TODO_IN_THIS_PR: Replace fmt.Printf with proper logging |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
| SendEnabled: IbcTransferParamSendEnabled, | ||
| ReceiveEnabled: IbcTransferParamReceiveEnabled, | ||
| } | ||
| // TODO_IN_THIS_PR: Replace fmt.Printf with proper logging |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
| HostEnabled: IbcIcaHostParamHostEnabled, | ||
| AllowMessages: IbcIcaHostParamAllowMessages, | ||
| } | ||
| // TODO_IN_THIS_PR: Replace fmt.Printf with proper logging |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
| ibcIcaControllerParams := icacontrollertypes.Params{ | ||
| ControllerEnabled: IbcIcaControllerParamControllerEnabled, | ||
| } | ||
| // TODO_IN_THIS_PR: Replace fmt.Printf with proper logging |
There was a problem hiding this comment.
[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
Review of #1262