Skip to content

[Review] Review of #1262: [IBC] Prepare pocket for IBC connectivity#1624

Merged
bryanchriswhite merged 1 commit intochore/ibcfrom
review_chore/ibc
Jul 14, 2025
Merged

[Review] Review of #1262: [IBC] Prepare pocket for IBC connectivity#1624
bryanchriswhite merged 1 commit intochore/ibcfrom
review_chore/ibc

Conversation

@Olshansk
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk commented Jul 3, 2025

Review of #1262

@Olshansk Olshansk requested a review from bryanchriswhite July 3, 2025 02:10
@Olshansk Olshansk self-assigned this Jul 3, 2025
@Olshansk Olshansk added ibc everything IBC related review A PR that's intended as a review of another PR labels Jul 3, 2025
@Olshansk Olshansk added this to Shannon Jul 3, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Shannon Jul 3, 2025
@Olshansk Olshansk changed the base branch from main to chore/ibc July 3, 2025 02:10
Comment thread app/upgrades/vNEXT.go
ibcConnectionParams := connectiontypes.Params{
MaxExpectedTimePerBlock: uint64(ibcConnectionParamMaxExpectedTimePerBlock.Nanoseconds()),
}
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging

Comment thread app/upgrades/vNEXT.go
Timestamp: uint64(ibcChannelParamUpgradeTimeoutTimestamp.Nanoseconds()),
},
}
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging

Comment thread app/upgrades/vNEXT.go
ibcClientParams := ibcclienttypes.Params{
AllowedClients: IbcClientParamAllowedClients,
}
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging

Comment thread app/upgrades/vNEXT.go
SendEnabled: IbcTransferParamSendEnabled,
ReceiveEnabled: IbcTransferParamReceiveEnabled,
}
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging

Comment thread app/upgrades/vNEXT.go
HostEnabled: IbcIcaHostParamHostEnabled,
AllowMessages: IbcIcaHostParamAllowMessages,
}
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging

Comment thread app/upgrades/vNEXT.go
ibcIcaControllerParams := icacontrollertypes.Params{
ControllerEnabled: IbcIcaControllerParamControllerEnabled,
}
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[linter-name (fail-on-found)] reported by reviewdog 🐶
// TODO_IN_THIS_PR: Replace fmt.Printf with proper logging

@bryanchriswhite bryanchriswhite merged commit 0973709 into chore/ibc Jul 14, 2025
12 of 13 checks passed
@github-project-automation github-project-automation bot moved this from 📋 Backlog to ✅ Done in Shannon Jul 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ibc everything IBC related review A PR that's intended as a review of another PR

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants