Skip to content

[RelayMiner] Avoid concurrent access to shared logger#1636

Merged
Olshansk merged 8 commits intomainfrom
logging_rm_panic
Jul 4, 2025
Merged

[RelayMiner] Avoid concurrent access to shared logger#1636
Olshansk merged 8 commits intomainfrom
logging_rm_panic

Conversation

@Olshansk
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk commented Jul 3, 2025

Fixing RelayMiner log panic reported by the community:

  • Root Cause: Multiple goroutines tried to use the same logger.
  • Solution: Create context-specific loggers.

Side change: fixing some broken tests on main.

Screenshot 2025-07-03 at 4 52 14 PM

@Olshansk Olshansk requested a review from red-0ne July 3, 2025 23:52
@Olshansk Olshansk self-assigned this Jul 3, 2025
@Olshansk Olshansk added bug Something isn't working relayminer Changes related to the Relayminer tooling Tooling - CLI, scripts, helpers, off-chain, etc... labels Jul 3, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Shannon Jul 3, 2025
@Olshansk Olshansk moved this from 📋 Backlog to 🏗 In progress in Shannon Jul 3, 2025
@Olshansk Olshansk changed the title Fixing logging issues reported by the community [RelayMiner] Avoid concurrent access to shared logger Jul 3, 2025
@Olshansk Olshansk moved this from 🏗 In progress to 👀 In review in Shannon Jul 4, 2025
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 4, 2025

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 1636)
Grafana network dashboard for devnet-issue-1636

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Jul 4, 2025
@Olshansk Olshansk marked this pull request as ready for review July 4, 2025 00:02
@Olshansk Olshansk merged commit cf38393 into main Jul 4, 2025
12 of 16 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Shannon Jul 4, 2025
bryanchriswhite added a commit that referenced this pull request Jul 16, 2025
* pokt/main: (69 commits)
  Refactor Tiltfile structure and enhance Pocketdex support. (#1640)
  [Morse Recovery] Updated Recovery Allowlist (#1651)
  [RelayMiner] Improve SafeReadBody concurrency safety by copying buffer data (#1650)
  Add a configurable max body size parameter to RelayMiner configuration. (#1566)
  Update upgrade_tx_v0.1.25_alpha.json
  feat: Improve relay request unmarshaling error handling and logging (#1649)
  [Docs] v0.1.25/26 upgrage artifacts (#1648)
  Remove settlement result from `EventClaimSettled` in `v0.127` release. (#1647)
  Revert "feat: Remove settlement result from EventClaimSettled" (#1643)
  [Code Health] Fix linter issues & attempt to fix flaky tests (#1646)
  Updating config-path-x.yaml with: schema header, owned app for config-path-1
  [Shannon SDK] Update the `shannon-sdk` in prep for `v0.1.26` (#1641)
  [RelayMiner] Add chain version retrieval functionality to block client (#1639)
  [RelayMiner] Avoid concurrent access to shared logger (#1636)
  [Telegram] Add Korbit channel to broadcast workflow (#1634)
  upgrade: Prepare upgrade plan for v0.1.26 (#1635)
  [RelayMiner] Add proper timeout handling for RelayMiner HTTP requests (#1595)
  [Code only] fix: implement backward compatible relay response signatures  (from #1629) (#1630)
  [Misc] Misc fixes & improvements (#1632)
  Added pocket-knife to ecosystem tools (#1622)
  ...
bryanchriswhite added a commit that referenced this pull request Jul 16, 2025
* refs/heads/chore/ibc: (69 commits)
  Refactor Tiltfile structure and enhance Pocketdex support. (#1640)
  [Morse Recovery] Updated Recovery Allowlist (#1651)
  [RelayMiner] Improve SafeReadBody concurrency safety by copying buffer data (#1650)
  Add a configurable max body size parameter to RelayMiner configuration. (#1566)
  Update upgrade_tx_v0.1.25_alpha.json
  feat: Improve relay request unmarshaling error handling and logging (#1649)
  [Docs] v0.1.25/26 upgrage artifacts (#1648)
  Remove settlement result from `EventClaimSettled` in `v0.127` release. (#1647)
  Revert "feat: Remove settlement result from EventClaimSettled" (#1643)
  [Code Health] Fix linter issues & attempt to fix flaky tests (#1646)
  Updating config-path-x.yaml with: schema header, owned app for config-path-1
  [Shannon SDK] Update the `shannon-sdk` in prep for `v0.1.26` (#1641)
  [RelayMiner] Add chain version retrieval functionality to block client (#1639)
  [RelayMiner] Avoid concurrent access to shared logger (#1636)
  [Telegram] Add Korbit channel to broadcast workflow (#1634)
  upgrade: Prepare upgrade plan for v0.1.26 (#1635)
  [RelayMiner] Add proper timeout handling for RelayMiner HTTP requests (#1595)
  [Code only] fix: implement backward compatible relay response signatures  (from #1629) (#1630)
  [Misc] Misc fixes & improvements (#1632)
  Added pocket-knife to ecosystem tools (#1622)
  ...

# Conflicts:
#	Makefile
#	Tiltfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working devnet devnet-test-e2e push-image CI related - pushes images to ghcr.io relayminer Changes related to the Relayminer tooling Tooling - CLI, scripts, helpers, off-chain, etc...

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

1 participant