Skip to content

[Foundation] Remove pulsar#1661

Merged
Olshansk merged 9 commits intomainfrom
remove_pulsar
Jul 11, 2025
Merged

[Foundation] Remove pulsar#1661
Olshansk merged 9 commits intomainfrom
remove_pulsar

Conversation

@Olshansk
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk commented Jul 10, 2025 •
edited
Loading

tl;dr Remove everything related to pulsar since it is not necessary post v0.52 and ignite no longer supports it

Proof of E2E Tests.
Screenshot 2025-07-10 at 2 34 47 PM

Screenshot 2025-07-10 at 1 54 23 PM

@github-actions github-actions bot added the consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. label Jul 10, 2025
@Olshansk Olshansk self-assigned this Jul 10, 2025
@Olshansk Olshansk added this to Shannon Jul 10, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Shannon Jul 10, 2025
@Olshansk Olshansk moved this from 📋 Backlog to 🔖 Ready in Shannon Jul 10, 2025
@Olshansk Olshansk moved this from 🔖 Ready to 🏗 In progress in Shannon Jul 10, 2025
@Olshansk Olshansk changed the title [WIP] Remove pulsar [Foundation] Remove pulsar Jul 10, 2025
@Olshansk Olshansk requested review from bryanchriswhite and red-0ne and removed request for red-0ne July 10, 2025 18:30
@github-actions
Copy link
Copy Markdown

github-actions bot commented Jul 10, 2025

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 1661)
Grafana network dashboard for devnet-issue-1661

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Jul 10, 2025
@Olshansk Olshansk requested a review from red-0ne July 10, 2025 18:31
@Olshansk Olshansk moved this from 🏗 In progress to 👀 In review in Shannon Jul 10, 2025
@Olshansk Olshansk removed the request for review from red-0ne July 11, 2025 00:25
bryanchriswhite
bryanchriswhite approved these changes Jul 11, 2025
View reviewed changes
Copy link
Copy Markdown
Collaborator

@bryanchriswhite bryanchriswhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preemptively approving. I had a couple of questions, but otherwise LGTM! 🚀

Comment thread proto/pocket/application/types.proto Outdated
Comment thread proto/pocket/application/module/module.proto
Comment thread proto/pocket/gateway/types.proto Outdated
Comment thread proto/pocket/proof/types.proto Outdated
Comment thread proto/pocket/session/types.proto Outdated
Comment thread buf.lock
Comment thread Makefile
@Olshansk
Copy link
Copy Markdown
Collaborator Author

Olshansk commented Jul 11, 2025

@bryanchriswhite Tended to your comments.

I'm going to be looking for 🟢 on E2E and unit tests (some of the other CIs are broken due to the size of the PR).

@Olshansk
Copy link
Copy Markdown
Collaborator Author

Olshansk commented Jul 11, 2025

Screenshot 2025-07-11 at 2 15 03 PM

@Olshansk Olshansk merged commit bb71909 into main Jul 11, 2025
10 of 14 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Shannon Jul 11, 2025
bryanchriswhite added a commit that referenced this pull request Jul 14, 2025
@bryanchriswhite
Merge remote-tracking branch 'pokt/main' into chore/ibc
6e53115 
* pokt/main: (34 commits)
  [RelayMiner] feat: relay miner routes to multiple backend URLs based on RPC Type (#1633)
  [Morse Recovery] Added new addresses for recovery (#1667)
  [DOCS][SERVICE] Adding danger for Grove employees on mainnet service creation (#1666)
  [Foundation] Remove `pulsar` (#1661)
  [RelayMiner] Add timeout support and improved logging to query clients (#1657)
  [RelayMiner] Replace buffer copying with explicit cleanup pattern in SafeReadBody (#1658)
  [Testing] Fixing flaky unit tests to make CI more reliable (#1662)
  [Scripts] Notes, events and queries to query `block` events and `tx` events (#1660)
  [Morse Recovery] Add recovery addresses for issue #1654 (#1656)
  Refactor Tiltfile structure and enhance Pocketdex support. (#1640)
  [Morse Recovery] Updated Recovery Allowlist (#1651)
  [RelayMiner] Improve SafeReadBody concurrency safety by copying buffer data (#1650)
  Add a configurable max body size parameter to RelayMiner configuration. (#1566)
  Update upgrade_tx_v0.1.25_alpha.json
  feat: Improve relay request unmarshaling error handling and logging (#1649)
  [Docs] v0.1.25/26 upgrage artifacts (#1648)
  Remove settlement result from `EventClaimSettled` in `v0.127` release. (#1647)
  Revert "feat: Remove settlement result from EventClaimSettled" (#1643)
  [Code Health] Fix linter issues & attempt to fix flaky tests (#1646)
  Updating config-path-x.yaml with: schema header, owned app for config-path-1
  ...
bryanchriswhite added a commit that referenced this pull request Jul 16, 2025
@bryanchriswhite
Merge remote-tracking branch 'pokt/chore/ibc' into chore/localnet/tilt
6345d73 
* pokt/chore/ibc:
  fix: TODOs
  fix: onchain upgrade
  [RelayMiner] feat: relay miner routes to multiple backend URLs based on RPC Type (#1633)
  [Morse Recovery] Added new addresses for recovery (#1667)
  [DOCS][SERVICE] Adding danger for Grove employees on mainnet service creation (#1666)
  [Foundation] Remove `pulsar` (#1661)
  [RelayMiner] Add timeout support and improved logging to query clients (#1657)
  [RelayMiner] Replace buffer copying with explicit cleanup pattern in SafeReadBody (#1658)
  [Testing] Fixing flaky unit tests to make CI more reliable (#1662)
  [Scripts] Notes, events and queries to query `block` events and `tx` events (#1660)
  [Morse Recovery] Add recovery addresses for issue #1654 (#1656)
  First review
bryanchriswhite added a commit that referenced this pull request Jul 16, 2025
@bryanchriswhite
Merge branch 'chore/localnet/tilt' into chore/ibc-axelar
b0ae014 
* chore/localnet/tilt: (88 commits)
  [Disk Utilization] refactor: remove unnecessary Msg.*Response fields (#1670)
  [RelayMiner] Bump SMT version (#1675)
  [IBC] Prepare pocket for IBC connectivity (#1262)
  fix: TODOs
  fix: onchain upgrade
  [RelayMiner] feat: relay miner routes to multiple backend URLs based on RPC Type (#1633)
  [Morse Recovery] Added new addresses for recovery (#1667)
  [DOCS][SERVICE] Adding danger for Grove employees on mainnet service creation (#1666)
  [Foundation] Remove `pulsar` (#1661)
  [RelayMiner] Add timeout support and improved logging to query clients (#1657)
  [RelayMiner] Replace buffer copying with explicit cleanup pattern in SafeReadBody (#1658)
  [Testing] Fixing flaky unit tests to make CI more reliable (#1662)
  [Scripts] Notes, events and queries to query `block` events and `tx` events (#1660)
  [Morse Recovery] Add recovery addresses for issue #1654 (#1656)
  fixup! upgrade
  fixup! upgrade
  revertme: testing
  fixup! upgrade
  Refactor Tiltfile structure and enhance Pocketdex support. (#1640)
  [Morse Recovery] Updated Recovery Allowlist (#1651)
  ...
bryanchriswhite added a commit that referenced this pull request Jul 16, 2025
@bryanchriswhite
Merge branch 'chore/ibc-axelar' into feat/ibc/packet-forward-middleware
945ac18 
* chore/ibc-axelar: (92 commits)
  [Disk Utilization] refactor: remove unnecessary Msg.*Response fields (#1670)
  [RelayMiner] Bump SMT version (#1675)
  [IBC] Prepare pocket for IBC connectivity (#1262)
  fix: TODOs
  fix: onchain upgrade
  [RelayMiner] feat: relay miner routes to multiple backend URLs based on RPC Type (#1633)
  [Morse Recovery] Added new addresses for recovery (#1667)
  [DOCS][SERVICE] Adding danger for Grove employees on mainnet service creation (#1666)
  [Foundation] Remove `pulsar` (#1661)
  [RelayMiner] Add timeout support and improved logging to query clients (#1657)
  [RelayMiner] Replace buffer copying with explicit cleanup pattern in SafeReadBody (#1658)
  [Testing] Fixing flaky unit tests to make CI more reliable (#1662)
  [Scripts] Notes, events and queries to query `block` events and `tx` events (#1660)
  [Morse Recovery] Add recovery addresses for issue #1654 (#1656)
  fixup! upgrade
  fixup! upgrade
  revertme: testing
  fixup! upgrade
  Refactor Tiltfile structure and enhance Pocketdex support. (#1640)
  [Morse Recovery] Updated Recovery Allowlist (#1651)
  ...
bryanchriswhite added a commit that referenced this pull request Jul 16, 2025
@bryanchriswhite
Merge branch 'chore/ibc-axelar' into docs/ibc/localnet
d2ea329 
* chore/ibc-axelar: (88 commits)
  [Disk Utilization] refactor: remove unnecessary Msg.*Response fields (#1670)
  [RelayMiner] Bump SMT version (#1675)
  [IBC] Prepare pocket for IBC connectivity (#1262)
  fix: TODOs
  fix: onchain upgrade
  [RelayMiner] feat: relay miner routes to multiple backend URLs based on RPC Type (#1633)
  [Morse Recovery] Added new addresses for recovery (#1667)
  [DOCS][SERVICE] Adding danger for Grove employees on mainnet service creation (#1666)
  [Foundation] Remove `pulsar` (#1661)
  [RelayMiner] Add timeout support and improved logging to query clients (#1657)
  [RelayMiner] Replace buffer copying with explicit cleanup pattern in SafeReadBody (#1658)
  [Testing] Fixing flaky unit tests to make CI more reliable (#1662)
  [Scripts] Notes, events and queries to query `block` events and `tx` events (#1660)
  [Morse Recovery] Add recovery addresses for issue #1654 (#1656)
  fixup! upgrade
  fixup! upgrade
  revertme: testing
  fixup! upgrade
  Refactor Tiltfile structure and enhance Pocketdex support. (#1640)
  [Morse Recovery] Updated Recovery Allowlist (#1651)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@bryanchriswhite bryanchriswhite bryanchriswhite approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@Olshansk Olshansk

Labels

consensus-breaking IMPORTANT! If the PR with this tag is merged, next release WILL HAVE TO BE an upgrade. devnet devnet-test-e2e push-image CI related - pushes images to ghcr.io

Projects

Shannon
Status: ✅ Done

Milestone

RelayMiner Stability

Development

Successfully merging this pull request may close these issues.

2 participants

@Olshansk @bryanchriswhite