Skip to content

fix: use local GUARD values.yaml for overriding temporary values#1732

Merged
Olshansk merged 7 commits intomainfrom
fix-guard-override
Aug 18, 2025
Merged

fix: use local GUARD values.yaml for overriding temporary values#1732
Olshansk merged 7 commits intomainfrom
fix-guard-override

Conversation

@commoddity
Copy link
Copy Markdown
Contributor

@commoddity commoddity commented Aug 18, 2025

🌿 Summary

Add local guard-overrides.yaml file and update Tiltfile to use it for temporary GUARD configuration overrides.

🌱 Primary Changes:

  • Added guard-overrides.yaml with workarounds for Envoy Ratelimit Service and extension hooks errors
  • Updated Tiltfile to use local values file for GUARD configuration overrides

🍃 Secondary changes:

  • Added documentation comments explaining the temporary workarounds
  • Included Discord discussion links for context on the issues being addressed

🛠️ Type of change

Select one or more from the following:

  • Bug fix

@Olshansk Olshansk added this to the Protocol R&D milestone Aug 18, 2025
@Olshansk Olshansk added this to Shannon Aug 18, 2025
@github-project-automation github-project-automation bot moved this to 📋 Backlog in Shannon Aug 18, 2025
@Olshansk Olshansk moved this from 📋 Backlog to 👀 In review in Shannon Aug 18, 2025
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commoddity NOTE: I haven't debugged.

My expectation with this PR: make localnet_down && make localnet_up will "simply work" out of the box w/ a new poktroll repo.

What's the expectation with this PR from your POV?

Here is what I've done:

git clone git@github.com:pokt-network/poktroll.git poktroll
cd poktroll
make localnet_up
# go to http://localhost:10350/

Going to start debugging...
Screenshot 2025-08-18 at 11 42 26 AM

Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@commoddity NOTE: I haven't debugged.

My expectation with this PR: make localnet_down && make localnet_up will "simply work" out of the box w/ a new poktroll repo.

What's the expectation with this PR from your POV?

Here is what I've done:

git clone git@github.com:pokt-network/poktroll.git poktroll
cd poktroll
gcor fix-guard-override
make localnet_up
# go to http://localhost:10350/

Going to start debugging...
Screenshot 2025-08-18 at 11 42 26 AM

@github-actions
Copy link
Copy Markdown

The CI will now also run the e2e tests on devnet, which increases the time it takes to complete all CI checks.

You may need to run make trigger_ci to submit an empty commit that'll trigger the tests.

GCP workloads (requires changing the namespace to 1732)
Grafana network dashboard for devnet-issue-1732

@github-actions github-actions bot added devnet push-image CI related - pushes images to ghcr.io labels Aug 18, 2025
@Olshansk Olshansk requested review from okdas and removed request for bryanchriswhite August 18, 2025 19:09
Copy link
Copy Markdown
Collaborator

@Olshansk Olshansk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushed some more changes.

Got 🟢 and successful relay ✅

Screenshot 2025-08-18 at 12 10 46 PM

@Olshansk Olshansk merged commit 53283cf into main Aug 18, 2025
11 checks passed
@github-project-automation github-project-automation bot moved this from 👀 In review to ✅ Done in Shannon Aug 18, 2025
@Olshansk Olshansk deleted the fix-guard-override branch August 18, 2025 20:19
bryanchriswhite added a commit that referenced this pull request Aug 20, 2025
…lidator-delegator-rewards

* pokt/main:
  [Validator] Documentation / Playbook to track rewards (#1725)
  Minor fix to docs
  Minor update to release_tag_rc
  feat: Add in-memory SMT storage option for RelayMiner (#1730)
  fix: use local GUARD values.yaml for overriding temporary values (#1732)
  [PARAMS][GOVERNANCE] Updating CUTTM per Foundation request (#1733)
  [Migration] chore: update Morse account recovery allowlist (#1731)
bryanchriswhite added a commit that referenced this pull request Aug 22, 2025
* pokt/main:
  [RelayMiner] Fix for in-memory SMT (#1730 followup) (#1737)
  [Validator] Documentation / Playbook to track rewards (#1725)
  Minor fix to docs
  Minor update to release_tag_rc
  feat: Add in-memory SMT storage option for RelayMiner (#1730)
  fix: use local GUARD values.yaml for overriding temporary values (#1732)
  [PARAMS][GOVERNANCE] Updating CUTTM per Foundation request (#1733)
  [Migration] chore: update Morse account recovery allowlist (#1731)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

devnet devnet-test-e2e localnet push-image CI related - pushes images to ghcr.io

Projects

Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants