Open
Conversation
Collaborator
|
@Abhilashaa08 This is great - ty! Any chance you could share a video or screenshot of you running it? Would also appreciate if you can upadate the GitHub description. |
Olshansk
requested changes
Oct 16, 2025
Comment on lines
+40
to
+44
| brew install gnu-sed | ||
| brew install grep | ||
| brew install yq | ||
| brew install kind | ||
| brew install tilt |
Collaborator
There was a problem hiding this comment.
Can we single line this?
Comment on lines
+46
to
+48
| # Verify Go version (must be 1.23.x, NOT 1.24+) | ||
| go version | ||
| # Expected output: go1.23.12 darwin/arm64 |
Collaborator
There was a problem hiding this comment.
Is there a way to update go.mod or other tooling to avoid additional cognitive overhead on the reader?
|
|
||
| ``` | ||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
Please fix spacing here and below
| # Initialize accounts (required for relays & tests) | ||
| make acc_initialize_pubkeys POCKET_NODE=http://localhost:26657 | ||
| ``` | ||
| Troubleshooting |
|
|
||
|
|
||
|
|
||
| # Quickstart (Localnet) |
Collaborator
There was a problem hiding this comment.
Suggested change
| # Quickstart (Localnet) | |
| ## Quickstart (Localnet) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
< Improve onboarding instructions by updating the README.md with clear prerequisites, quickstart steps, and troubleshooting notes for running make localnet_up.>
Primary Changes:
Secondary Changes:
Issue
Type of change
Select one or more from the following:
Sanity Checklist
assignees,reviewers,labels,project,iterationandmilestonemake docusaurus_startmake go_develop_and_testandmake test_e2edevnet-test-e2elabel to run E2E tests in CImake test_e2e_oneshot