fix(python): Handle non-Sequence iterables in filter#16254
Merged
alexander-beedie merged 7 commits intopola-rs:mainfrom May 22, 2024
Merged
fix(python): Handle non-Sequence iterables in filter#16254alexander-beedie merged 7 commits intopola-rs:mainfrom
alexander-beedie merged 7 commits intopola-rs:mainfrom
Conversation
2 tasks
dangotbanned
commented
May 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16254 +/- ##
==========================================
- Coverage 81.39% 81.37% -0.03%
==========================================
Files 1406 1406
Lines 183953 183955 +2
Branches 2958 2959 +1
==========================================
- Hits 149731 149694 -37
- Misses 33709 33748 +39
Partials 513 513 ☔ View full report in Codecov by Sentry. |
dangotbanned
commented
May 16, 2024
24c125a to
1c5ebd9
Compare
Adapted from @alexander-beedie on [discord](https://discord.com/channels/908022250106667068/908022461751234570/1242428077955354684). I added 2 non-expression cases for the boolean masks.
Contributor
Author
|
@alexander-beedie hoping this is good to go now |
alexander-beedie
approved these changes
May 22, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #16253
I tried to keep the logic as close to the original as possible.
E.g, prioritising the fast paths.
Was wondering if the
is_sequencecheck that follows is the best option though.Edit:
To elaborate on the
is_sequencecomment further.Acceptable inputs at that stage are:
Exprstrrepresenting a column name inself.columnsSequencethat is not aSeriesWhere parsing
3is defered toparse_as_list_of_expressions.