Skip to content

fix: Handle Parquet with compressed empty DataPage v2#22172

Merged
orlp merged 1 commit into
pola-rs:mainfrom
EnricoMi:datapage-v2-empty
Apr 8, 2025
Merged

fix: Handle Parquet with compressed empty DataPage v2#22172
orlp merged 1 commit into
pola-rs:mainfrom
EnricoMi:datapage-v2-empty

Conversation

@EnricoMi
Copy link
Copy Markdown
Contributor

@EnricoMi EnricoMi commented Apr 8, 2025

Closes #22170.

The issue is identical to this Apache Arrow issue: apache/arrow#22459
The fix is identical to Apache Arrow fix: apache/arrow#45252

@github-actions github-actions Bot added fix Bug fix python Related to Python Polars rust Related to Rust Polars labels Apr 8, 2025
@EnricoMi EnricoMi changed the title fix: Handle compressed empty DataPage v2 fix: Handle Parquet with compressed empty DataPage v2 Apr 8, 2025
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.60%. Comparing base (a457723) to head (13e74e2).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #22172      +/-   ##
==========================================
- Coverage   80.97%   80.60%   -0.37%     
==========================================
  Files        1640     1640              
  Lines      237033   236802     -231     
  Branches     2714     2714              
==========================================
- Hits       191932   190878    -1054     
- Misses      44462    45285     +823     
  Partials      639      639              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@EnricoMi EnricoMi force-pushed the datapage-v2-empty branch from c9bdfdc to 13e74e2 Compare April 8, 2025 13:26
Copy link
Copy Markdown
Member

@orlp orlp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks :)

@orlp orlp merged commit 999812e into pola-rs:main Apr 8, 2025
26 checks passed
@EnricoMi EnricoMi deleted the datapage-v2-empty branch April 8, 2025 20:16
@EnricoMi
Copy link
Copy Markdown
Contributor Author

EnricoMi commented Apr 8, 2025

Thanks!

coastalwhite pushed a commit to coastalwhite/polars that referenced this pull request Apr 10, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Bug fix python Related to Python Polars rust Related to Rust Polars

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Handle Parquet with compressed empty DataPage v2

2 participants