Automatically downgrade/fallback bundled signatures to next lower version if missing#274
Merged
Conversation
…ad of searching classpath
decb53d to
1fca0ba
Compare
…) and cleanup api
833e2c3 to
a33e191
Compare
Member
Author
|
I think this is ready now, will merge soon. This improvement will allow the following:
This allows to refer to newer commons-io versions than the ones released as bundled signatures. A warning is printed. This warning implicitely suggests to update forbiddenapis once a new version is available, but this is not clearly communicated to prevent users from opening issues and requesting new versions (hopefully). |
This was referenced Sep 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #273.
The code is in early stage, but works. I added a version comparator and a comparator for bundled-signatures names. The comparator may not be the fastest, but should work correctly.