Conversation
This is generally a better practice. It seems to make the code slightly neater, or comparable. BREAKING CHANGE: This changes the public API of the crate. However, it shouldn't change the behavior of the program other than somewhat different error messages for crashes.
Member
|
The error messages for an unexpected argument and for the daemon needing to be run as root look identical before and after the change. The error message for if the daemon's not running is less descriptive after the change. Before: After: The former message gives a bigger hint to check if the system76-power service is running. Is removing that part necessary/intentional? |
Member
Author
|
Hm. No, not intentional. That's definitely not a descriptive enough message. |
bflanagin
reviewed
Jan 26, 2021
bflanagin
left a comment
bflanagin
left a comment
There was a problem hiding this comment.
This PR seems to be out of date, and needs attention. Will reassess when updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is generally a better practice. It seems to make the code slightly neater, or comparable.
BREAKING CHANGE: This changes the public API of the crate. However, it shouldn't change the behavior of the program other than somewhat different error messages for crashes.