fix: avoid 5s timeout when revealing plotly widgets#240
Merged
Conversation
waitForPlotlyAfterPlot listened for the plotly_afterplot event, but by the time the listener attached, Plotly had typically already fired it. This caused every plotly widget to hit the 5-second fallback timeout before becoming visible. Check plotEl._fullLayout to detect that Plotly already completed its render and resolve immediately, skipping the wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
plotlyin0.8.0#239 — significant performance degradation for plotly in 0.8.0waitForPlotlyAfterPlotlistener was attaching after Plotly had already emittedplotly_afterplot, causing every plotly widget to hit the 5-second fallback timeout before becoming visibleplotEl._fullLayoutto detect that Plotly already completed its render, resolving immediately instead of waitingTest plan
test_example_plotly_afterplot_stable,test_plotly_rerender_cleanup)