Closed
Conversation
OJFord
reviewed
Aug 7, 2024
Comment on lines
+671
to
675
| \ifempty{#1#4} | ||
| {\entrytitlestyle{#2} & \entrylocationstyle{#3} \\} | ||
| \ifempty{#1#3} | ||
| {\entrytitlestyle{#2} & \entrydatestyle{#4} \\} | ||
| {\entrytitlestyle{#2} & \entrylocationstyle{#3} \\ |
Collaborator
There was a problem hiding this comment.
If 1 & 4 (position & date) are empty, doesn't this mean we show double 2 (title) regardless of 3 or anything else?
Contributor
Author
There was a problem hiding this comment.
Won't show 2 twice but should throw lots of errors and possibly fail to build in some situations, like if only 2 is not empty. Also doesn't fix the issue with \ifempty where when the "if" conditions are not satisfied the "else" doesn't print as expected because missing args.
If we want something user-proof this is a half measure and not much better than what's there already. Probably worse in certain cases too. 5 args with 2 states is...quite a few combinations to account for and this probably isn't the place or way to handle it in the .cls file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for empty position + date and empty position + location which should resolve issue #476, #327, #249, #247, #155 and addresses the issues addressed in unmerged (and conflicted) #428.
Edit: And possible bug from #499 couldn't be reproduced, so resolves that too?